-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Improve diff file headers #36215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve diff file headers #36215
Conversation
* origin/main: Closed milestones with no issues now show as 100% completed (go-gitea#36220) Show edit page confirmation dialog on tree view file change (go-gitea#36130) Fix regression in writing authorized principals (go-gitea#36213) [skip ci] Updated translations via Crowdin Convert locale files from ini to json format (go-gitea#35489)
|
This is ready, I've updated OP and cleaned up the PR comments. |
Why the change is better? |
03e4b7b to
9b8ef1f
Compare
The box shadow hack was only for a problem only visible when the header was sticky, it shouldn't have any affect for non-sticky content. |
If you'd like to remove it, I am also fine. It doesn't really bother me. Simpler is better. |
|
The last problem in my mind: The problems:
Personally I prefer to use also see the screenshot in #36215 (comment)
|
|
Yeah I think we can consistently capitalize these tags. |
|
I found some new things: there are some webkit-specfic styles: I am not sure it really works well for various cases, or it works for other browsers. It seems not easy to change these styles at the moment. Not bad on firefox: Anyway, let's merge and try and do more improvements in the future (if necessary) |
|
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/line-clamp |
* giteaofficial/main: fill missing `has_code` in repository api (go-gitea#36338) Fix notifications pagination query parameters (go-gitea#36351) Fix cancel auto merge bug (go-gitea#36341) Bump appleboy/git-push-action from 1.0.0 to 1.2.0 (go-gitea#36306) Improve diff file headers (go-gitea#36215) Fix delete attachment check (go-gitea#36320) [skip ci] Updated translations via Crowdin LFS locks must belong to the intended repo (go-gitea#36344) Update chroma to v2.22.0 (go-gitea#36342) Update goldmark to v1.7.16 (go-gitea#36343) Fix some trivial problems (go-gitea#36336) Fix diff view style handling (go-gitea#36324) Refactor cat-file batch operations and support `--batch-command` approach (go-gitea#35775) Fix file-tree ui error when adding files to repo without commits (go-gitea#36312)












Before
After